fix(astro): Protect component prop types #3846
Conversation
🦋 Changeset detectedLatest commit: 6c66ae7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| ( | ||
| | { | ||
| condition?: never; | ||
| role: OrganizationCustomRoleKey; | ||
| permission?: never; | ||
| } | ||
| | { | ||
| condition?: never; | ||
| role?: never; | ||
| permission: OrganizationCustomPermissionKey; | ||
| } | ||
| | { | ||
| condition: (has: CheckAuthorizationWithCustomPermissions) => boolean; | ||
| role?: never; | ||
| permission?: never; | ||
| } | ||
| | { | ||
| condition?: never; | ||
| role?: never; | ||
| permission?: never; | ||
| } | ||
| ) & { |
There was a problem hiding this comment.
We need to separate the prop types of the Astro component and React component since the Astro one has no build step and imported types will not be resolvable.
There was a problem hiding this comment.
Would the astro prop types need fallback: never; added?
There was a problem hiding this comment.
If the purpose of adding fallback: never is to show an error whenever unexpected props are used in Astro <Protect />, we don't need it it since it should already show type errors for random props
Also just FYI, Astro does not support typed slots
3 participants
Description
This PR addresses an issue where the
<Protect />component was accepting any prop without TypeScript raising errors. All the Astro components does not have a build step, and directly copied tocomponents/*, so relative paths will not be resolvable.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change